[PATCH] gas/Dwarf: properly skip zero-size functions

Nick Clifton nickc@redhat.com
Tue Aug 9 14:51:09 GMT 2022


Hi Jan,

> +	  expressionS size = { .X_op = O_constant };

Does this expression guarantee that the other fields in size are
initialised to zero ?  If not, then:

> +#endif
> +	  if (size.X_op == O_constant && size.X_add_number == 0)
> +	    continue;

size.X_add_number could be uninitialized here.

Apart from fixing that, (if I am right about designated initializers), the
rest of the patch looks fine to me.

Cheers
   Nick



More information about the Binutils mailing list