[PATCH] elf: Reset alignment for each PT_LOAD segment
H.J. Lu
hjl.tools@gmail.com
Wed Aug 3 17:06:42 GMT 2022
On Wed, Aug 3, 2022 at 1:45 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 02.08.2022 01:11, H.J. Lu via Binutils wrote:
> > --- a/bfd/elf.c
> > +++ b/bfd/elf.c
> > @@ -5439,7 +5439,7 @@ assign_file_positions_for_load_sections (bfd *abfd,
> > file_ptr off; /* Octets. */
> > bfd_size_type maxpagesize;
> > bfd_size_type p_align;
> > - bool p_align_p = false;
> > + bool p_align_p;
>
> Wouldn't it be helpful / good practice to also move the two variables
Good point.
> into the loop's scope (and then using initializers in favor of
> assignments)? Okay preferably with that adjustment.
>
> Jan
This is the patch I am checking in:
https://sourceware.org/pipermail/binutils/2022-August/122191.html
Thanks.
--
H.J.
More information about the Binutils
mailing list