[PATCH] x86: Print {bad} on invalid broadcast in OP_E_memory
Jan Beulich
jbeulich@suse.com
Mon Sep 27 11:32:34 GMT 2021
On 27.09.2021 13:28, Cui, Lili wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Monday, September 27, 2021 6:12 PM
>> To: Cui, Lili <lili.cui@intel.com>
>> Cc: binutils@sourceware.org; hjl.tools@gmail.com
>> Subject: Re: [PATCH] x86: Print {bad} on invalid broadcast in OP_E_memory
>
>> I've indicated so in the past already (perhaps not to you, but in
>> general): I consider it wrong to add test cases with bogus expectations.
>> In the case here it's not only the broadcast that's invalid, but also the {%k7}.
>> For your purpose you don't need the masking part, so I'd like to ask that you
>> drop it. If and when we properly mark such bad uses of masking, a separate
>> test case covering that aspect will want adding, but the one you add now
>> would then better not require adjusting.
>>
> Yes, we don’t need masking part here, I dropped it. Thanks.
Thanks, looks okay to me, but will need H.J.'s approval.
Jan
More information about the Binutils
mailing list