[PATCH][bfd, opcodes] Remove C99 constructs

[Tom de Vries]

On 9/24/21 3:12 AM, Alan Modra wrote:
> On Thu, Sep 23, 2021 at 10:39:35PM +0200, Tom de Vries via Binutils wrote:
>> Hi,
>>
>> When doing a gdb build with --enable-targets=all and gcc-4.8, we run into
>> build errors.
>>
>> Two of those are in bfd and opcodes, related to using for loop initial
>> declarations.  This is a C99 construct which is not availabe by default with
>> gcc-4.8.
> 
> So why is AC_PROG_CC_C99 in the top level makefile not effective for
> you?  I can successfully build binutils with gcc-4.8.  For me the
> build system automatically adds -std=gnu99.
> 

Because I was doing:
...
$ configure CC=gcc-4.8 CXX=g++-4.8
...
followed by:
...
$ make CC=gcc-4.8 CXX=g++-4.8
...
and the latter overrides the -std=c99 addition by configure.

So, my mistake, thanks for pointing this out.  I've updated my build script.

Thanks,
- Tom