[PATCH] [gas] Fix file 0 dir with -gdwarf-5

Tom de Vries tdevries@suse.de
Fri Nov 26 20:22:06 GMT 2021


On 11/26/21 6:51 PM, H.J. Lu wrote:
> On Fri, Nov 26, 2021 at 12:54 AM Nick Clifton via Binutils
> <binutils@sourceware.org> wrote:
>>
>> Hi Tom,
>>
>>> 2021-11-26  Tom de Vries  <tdevries@suse.de>
>>>
>>>       PR 28629
>>>       * dwarf2dbg.c (out_dir_and_file_list): When copying file 1 to file 0,
>>>       also copy dir and md5 fields.
>>>       * testsuite/gas/i386/dwarf5-line-4.d: Adjust expected output.
>>
>> Approved  - please apply.
> 
> This is caused:
> 
> FAIL: Check line table is produced with .nops
> 

Hi,

thanks for finding and fixing this.

FWIW, I'm still not sure how the test-case failed for you, it passes for
me.  The emit_md5 stays false, so the faulty code is never triggered.

Perhaps you found this by using the patch in context of some branch
where md5sum generation is enabled by default?

Thanks,
- Tom


More information about the Binutils mailing list