[PATCH] Use section name in warnings in display_debug_loc

Tom Tromey tromey@adacore.com
Thu Nov 4 15:35:13 GMT 2021


>>>>> "Andreas" == Andreas Schwab <schwab@linux-m68k.org> writes:

Andreas> On Nov 02 2021, Tom Tromey via Binutils wrote:
>> -		warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"),
>> +		warn (_("There is a hole [0x%lx - 0x%lx] in %s section.\n"),

Andreas> Perhaps the section name should be put in quotes?  I think that would
Andreas> give translators a hint that it is some kind of literal.

I looked and couldn't find any other section name in dwarf.c (either via
%s or hard-coded) in a printf that is quoted.  However, there were
multiple existing uses like "%s section" or "section %s".

So, while I think this change would be fine (I don't have a strong
opinion on its desirability), I think that if it is done, it should be
done for all the binutils at once.

thanks,
Tom


More information about the Binutils mailing list