[PATCH] RISC-V: Fix big endian disassembly of data.

[Guy Benyei]

Thanks, I'll send an updated patch.
      Guy

-----Original Message-----
From: Maciej W. Rozycki <macro@embecosm.com> 
Sent: Thursday, November 4, 2021 2:18 PM
To: Guy Benyei <guybe@nvidia.com>
Cc: binutils@sourceware.org; Kito Cheng <kito.cheng@sifive.com>; Marcus Comstedt <marcus@mc.pp.se>
Subject: Re: [PATCH] RISC-V: Fix big endian disassembly of data.

External email: Use caution opening links or attachments


On Mon, 1 Nov 2021, Guy Benyei via Binutils wrote:

> opcodes/
>       * riscv-dis.c: Consider endiannes when printing data
>
> gas/
>       * testsuite/gas/riscv/mapping-03b.d: check only for little endian
>       * testsuite/gas/riscv/mapping-04b.d: likewise
>       * testsuite/gas/riscv/mapping-norelax-03b.d: likewise
>       * testsuite/gas/riscv/mapping-norelax-04b.d: likewise
>       * testsuite/gas/riscv/mapping-03bbe.d: big endian data/code mapping test
>       * testsuite/gas/riscv/mapping-04bbe.d: likewise
>       * testsuite/gas/riscv/mapping-norelax-03bbe.d: likewise
>       * testsuite/gas/riscv/mapping-norelax-04bbe.d: likewise

 You need to improve these entries a bit, by making them proper sentences starting with a capital letter and ending with a full stop, e.g.:

        * testsuite/gas/riscv/mapping-03b.d: Check only for little endian.

(I think "endianness" would be more correct here too).  Also do not post actual ChangeLog diffs as that makes a patch not apply anymore very soon
-- the committer will make them from the template given in the commit description.

 Given that these test cases cover a disassembler rather than GAS feature please consider putting them in the binutils testsuite instead, that is in binutils/testsuite/binutils-all/riscv/.

  Maciej