[PATCH v2] opcodes: cris: move desc & opc files from sim/
Mike Frysinger
vapier@gentoo.org
Mon May 24 01:23:05 GMT 2021
On 23 May 2021 22:52, Hans-Peter Nilsson wrote:
> > From: Mike Frysinger <vapier@gentoo.org>
> > Date: Sun, 23 May 2021 06:12:51 +0200
>
> Missing ChangeLog entries. Those are "still" kept for opcodes/.
i don't waste time on these until i actually push the change
> > All other cgen ports keep their desc & opc files under opcodes/, so
> > move the cris files over too. The cris-opc.c file is already here.
>
> The commit log is not updated since the first version:
> cris-opc.c isn't just "already there", it's "not generated by CGEN".
not sure what you mean. desc/opc files belong in the opcodes project. i'm
explaining why this commit is only moving opc.h and not opc.c in this commit.
if you want me to write something else here, just lemme know what you want
it to say.
> > diff --git a/opcodes/Makefile.am b/opcodes/Makefile.am
> > @@ -431,6 +435,16 @@ stamp-bpf: $(CGENDEPS) $(CPUDIR)/bpf.cpu $(CPUDIR)/bpf.opc
> > $(MAKE) run-cgen arch=bpf prefix=bpf \
> > archfile=$(CPUDIR)/bpf.cpu opcfile=$(CPUDIR)/bpf.opc
> >
> > +$(srcdir)/cris-desc.h $(srcdir)/cris-desc.c $(srcdir)/cris-opc.h \
> > + $(srcdir)/cris-opc.c $(srcdir)/cris-dis.c: $(CRIS_DEPS)
>
> This dependency isn't updated; cris-opc.c must not depend on
> $(CRIS_DEPS) (stamp-cris in maintainer-mode).
thanks, removed opc.c & dis.c
-mike
More information about the Binutils
mailing list