[PATCH] opcodes: cris: move desc & opc files from sim/

Hans-Peter Nilsson hp@axis.com
Thu May 20 13:21:00 GMT 2021


> From: Mike Frysinger <vapier@gentoo.org>
> Date: Thu, 20 May 2021 07:18:32 +0200

> On 20 May 2021 01:48, Hans-Peter Nilsson wrote:
> > From: Mike Frysinger <vapier@gentoo.org>
> > > On 19 May 2021 23:32, Hans-Peter Nilsson wrote:
> > > > From: Hans-Peter Nilsson <Hans-Peter.Nilsson@axis.com>
> > > > > From: Mike Frysinger via Binutils <binutils@sourceware.org>
> > > > > > All other cgen ports keep their desc & opc files under opcodes/, so
> > > > > > move the cris files over too.  The cris-opc.c file is already here.
> > > > > 
> > > > > Unline (most) other CGEN ports, the assembler and
> > > > > disassembler isn't generated from the CGEN description.  But
> > > > > that's not a reason to keep it different in this regard.
> > > > > 
> > > > > Ok with the appropriate opcodes/ChangeLog entry.  Thanks!
> > > > 
> > > > No, wait, NOT ok: cris-opc.c isn't CGEN-generated.  Please
> > > > fix so it isn't "regenerated".
> > > 
> > > you want me to delete the cris cgen rule entirely ?
> > 
> > "No" if you mean removing the regeneration rule for the
> > CGEN-generated CRIS files of course.
> > 
> > But, if you want to move the CRIS CGEN files to opcodes/,
> > there must be precautions to not overwrite the cris-opc.c
> > there.
> 
> from what i can tell, the opcodes/ script has no support for only generating
> a single file.  it wants to do them all.  so you want me to pull the desc
> logic out of sim/common/cgen.sh and into opcodes/cgen.sh so that cris can run
> that logic ?

I want you to do something, if anything, that works for CRIS
sim *and* binutils.  If your suggestion is sane to you, then
perhaps yes, but as the CGEN files aren't used for CRIS
binutils, leaving things as they are in sim may be even
simpler.

> it's hard to test as the cris cgen rules fail for me even now with syntax
> errors in the scm files.

Badness.  CGEN as in using sim/common/cgen.sh?  Is there an
issue entered in bugzilla?  I guess someone has been naughty
and didn't test a CGEN change properly.

brgds, H-P


More information about the Binutils mailing list