[PATCH v2] x86: don't use opcode_length to identify pseudo prefixes

H.J. Lu hjl.tools@gmail.com
Tue Mar 23 18:32:56 GMT 2021


On Tue, Mar 23, 2021 at 9:42 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> This is in preparation of opcode_length going away as a field in the
> templates. Identify pseudo prefixes by a base opcode of zero instead:
> No real prefix has an opcode of zero. This at the same time allows
> dropping a curious special case from i386-gen.
>
> Since most attributes are identical for all pseudo prefixes, take the
> opportunity and also template them.
>
> gas/
> 2021-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (parse_insn): Recognize pseudo prefixes by
>         base_opcode and extension_opcode.
>
> opcodes/
> 2021-03-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * i386-gen.c (process_i386_opcode_modifier): Drop IsPrefix
>         check.
>         * i386-opc.h (Prefix_*): Move #define-s.
>         * i386-opc.tbl: Move pseudo prefix enumerator values to
>         extension opcode field. Introduce pseudopfx template.
>         * i386-tbl.h: Re-generate.
> ---
> v2: Introduce PSEUDO_PREFIX and pseudopfx template.
>

OK.

Thanks.

-- 
H.J.


More information about the Binutils mailing list