[PATCH] bfd: avoid "shadowing" of glibc function name

Jan Beulich jbeulich@suse.com
Mon Mar 22 08:30:48 GMT 2021


Old enough glibc has an (unguarded) declaration of index() in string.h,
which triggers a "shadows a global declaration" warning.

bfd/
2021-03-XX  Jan Beulich  <jbeulich@suse.com>

	* dwarf2.c (read_indexed_string): Rename index to idx.

--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -1172,7 +1172,7 @@ is_str_attr (enum dwarf_form form)
 }
 
 static const char *
-read_indexed_string (bfd_uint64_t index ATTRIBUTE_UNUSED,
+read_indexed_string (bfd_uint64_t idx ATTRIBUTE_UNUSED,
 		     struct comp_unit * unit ATTRIBUTE_UNUSED)
 {
   /* FIXME: Add support for indexed strings.  */


More information about the Binutils mailing list