[PATCH 6/6] bfd: strip symbols not representable in COFF/PE symbol table

[Jan Beulich]

On 04.03.2021 07:15, Alan Modra wrote:
> On Tue, Mar 02, 2021 at 10:50:59AM +0100, Jan Beulich via Binutils wrote:
>> --- a/bfd/cofflink.c
>> +++ b/bfd/cofflink.c
>> @@ -2602,6 +2602,16 @@ _bfd_coff_write_global_sym (struct bfd_h
>>  			+ h->root.u.def.section->output_offset);
>>  	if (! obj_pe (flaginfo->output_bfd))
>>  	  isym.n_value += sec->vma;
>> +#ifdef BFD64
>> +	if (isym.n_value > (bfd_vma)0xffffffff)
> 
> space here after cast.

Oh, I see.

>> +	  {
>> +	    if (! h->root.linker_def)
>> +	      _bfd_error_handler
>> +	        (_("%pB: stripping non-representable symbol '%s' (value %"BFD_VMA_FMT"x)"),
> 
> overlong line.

What am I to do in this case? From other projects I'm used to the
rule that format strings, to remain grep-able, are allowed to
run past the normal line length limit. For now I'll split before
the opening parentheses, but I'll be waiting with committing this
anyway until I've tested this against a more complete set of
targets (like I'll also do for patch 5).

Jan