[PATCH 2/2] x86: fold some prefix related attributes into a single one

H.J. Lu hjl.tools@gmail.com
Wed Mar 3 20:03:43 GMT 2021

On Wed, Mar 3, 2021 at 3:53 AM Jan Beulich <jbeulich@suse.com> wrote:
> On 02.03.2021 17:54, H.J. Lu wrote:
> > On Tue, Mar 02, 2021 at 05:10:19PM +0100, Jan Beulich via Binutils wrote:
> >> RepPrefixOk, HLEPrefixOk, and NoTrackPrefixOk can't be specified
> >> together, so can share an enum-like field. IsLockable can be inferred
> >> from HLE setting and hence only needs specifying when neither of them
> >> is present.
> >>
> >> Where applicable also drop redundant Byte/Word/Dword/Qword operand
> >> attributes.
> >>
> >
> > Please separate Byte/Word/Dword/Qword changes from prefix changes.
> I don't think I'm going to take time to go through the tedious exercise
> of squashing redundant Byte/Word/Dword/Qword. If you don't want them
> (and perhaps similar cleanup) to happen while code gets touched anyway,
> it likely won't happen at all (unless you or somebody else takes the
> time). I wouldn't suggest doing such with non-obvious transformations,
> but the redundancy of Byte with Reg8 (etc) is extremely obvious.
> Please confirm that such on-the-fly cleanup really is unacceptable, in
> which case I'll simply drop these changes (and resubmit, and try to
> remember to never do so again, no matter how trivial the adjustment).

I prefer not mixing 2 unrelated changes in a single commit.


More information about the Binutils mailing list