[PATCH REVIEW 10/10] bfd, ld, libctf: skip zero-refcount strings in CTF string reporting

Nick Alcock nick.alcock@oracle.com
Tue Mar 2 15:16:37 GMT 2021


On 1 Mar 2021, Nick Clifton via Binutils verbalised:

>> +      ret = _bfd_elf_strtab_str (arg->strtab, arg->next_i++, &off);
>> +    } while (ret == 0);
>
> The while statement should be on its own line.  IE:
>
>     }
>   while (ret == 0);

It's also checking the return value of the same function you just
commented on, so it too should be comparing with NULL. (Adjusted,
pushed, thanks for spotting this mindless cut-and-pasto before it spread
too far!)


More information about the Binutils mailing list