[PATCH 1/6] x86: off-by-1 in offset_in_range()

[Jan Beulich]

On 17.06.2021 16:40, H.J. Lu wrote:
> On Mon, Jun 14, 2021 at 3:24 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Just like e.g. 0x10000 triggers a warning for size 2, -0x10000 ought to
>> as well.
>>
>> Note that some of the encodings produced aren't ones one would expect,
>> and hence the generated code is not being checked for in the new
>> testcases.
>>
>> gas/
>> 2021-06-XX  Jan Beulich  <jbeulich@suse.com>
>>
>>         * config/tc-i386.c (offset_in_range): Adjust conditional.
>>         * testsuite/gas/i386/disp-imm-16.s,
>>         testsuite/gas/i386/disp-imm-16.l,
>>         testsuite/gas/i386/disp-imm-64.s,
>>         testsuite/gas/i386/disp-imm-64.l: New.
>>         * testsuite/gas/i386/i386.exp: Run new tests.
>> ---
>> As for the new 16-bit test, see also the subsequent "x86: harmonize disp
>> with imm handling" - it's at least debatable whether wrapping (in 16
>> bits) wouldn't better match 32-bit code's wrapping in 32-bits, as (to
>> some degree at least, gets put in place there), in which case this
>> testcase may better not be added here, as it would then "document" wrong
>> behavior.
> 
> 
> OK.

Thanks, but did you perhaps miss that you had given your okay for the
entire series already on the 14th?

Jan