[PATCH] x86: cover a.out in recently added tests

[H.J. Lu]

On Thu, Jun 10, 2021 at 7:09 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 10.06.2021 15:34, H.J. Lu wrote:
> > Please try this patch to see if gas_bfd64_check works for you.
>
> Without having tried it yet, two questions: For one, is the
> AS_CLASS use in there rather meant to be AS_BFD64? And then, how

It should be AS_BFD64.

> is it going to help to check the as-new binary for a target (like
> a.out) which doesn't have said --help output line, when this can
> still be a 64-bit binary defaulting to BFD64 or a 32-bit one where
> ./configure simply was passed --enable-64-bit-bfd?

It isn't covered.

> Wouldn't it be more direct to check for a working .code64
> directive? Its availability directly depends on BFD64. Of course

Sure if it works.

> then a next question is whether gas_64_check really needs to be
> different from gas_bfd64_check (albeit the two then still wouldn't
> do the same checking).

They are different things. BFD64 can be used without --64.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-x86-Update-gas_bfd64_check-to-check-64-bit-ELF-as.patch
Type: text/x-patch
Size: 1620 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20210610/ac61eea1/attachment-0001.bin>