[PATCH] arm: fix array-out-of-bounds upon register parsing error

Richard Earnshaw Richard.Earnshaw@foss.arm.com
Thu Jun 10 10:29:26 GMT 2021


OK.

I wonder if we could somehow build in an assert to check this.  Even 
better would be a static assertion during compilation, but that might be 
harder.

On 10/06/2021 08:43, Jan Beulich via Binutils wrote:
> Despite the comment ahead of the enum explicitly pointing out the need
> to also update the corresponding array, 1b8833198c0 ("Add support for
> MVE instructions: vcmp and vpt") failed to do so. Oddly enough the issue
> appears to be spotted only by rather old gcc (4.3-ish in my case).
> 
> gas/
> 2021-06-XX  Jan Beulich  <jbeulich@suse.com>
> 
> 	* config/tc-arm.c (reg_expected_msgs): Add REG_TYPE_ZR entry.
> 
> --- a/gas/config/tc-arm.c
> +++ b/gas/config/tc-arm.c
> @@ -729,7 +729,8 @@ const char * const reg_expected_msgs[] =
>     [REG_TYPE_MMXWCG] = N_("iWMMXt scalar register expected"),
>     [REG_TYPE_XSCALE] = N_("XScale accumulator register expected"),
>     [REG_TYPE_MQ]	    = N_("MVE vector register expected"),
> -  [REG_TYPE_RNB]    = ""
> +  [REG_TYPE_RNB]    = "",
> +  [REG_TYPE_ZR]     = N_("ZR register expected"),
>   };
>   
>   /* Some well known registers that we refer to directly elsewhere.  */
> 


More information about the Binutils mailing list