Enable Intel AVX512_FP16 instructions and test

Jan Beulich jbeulich@suse.com
Fri Jul 23 16:04:25 GMT 2021


On 23.07.2021 17:42, Cui, Lili wrote:
>> From: Jan Beulich <jbeulich@suse.com>
>> Sent: Thursday, July 22, 2021 8:25 PM
>>
>> On 22.07.2021 09:04, Cui, Lili wrote:
>>> @@ -865,7 +880,9 @@ enum
>>>    MOD_EVEX_0F387B_W_0,
>>>    MOD_EVEX_0F387C,
>>>    MOD_EVEX_0F38C6,
>>> -  MOD_EVEX_0F38C7
>>> +  MOD_EVEX_0F38C7,
>>> +  MOD_EVEX_MAP5_10_PREFIX_1,
>>> +  MOD_EVEX_MAP5_11_PREFIX_1
>>>  };
>>
>> Just P_1 please, not PREFIX_1. It's only very old enumerators which still use
>> the overlong names.
>>
> They are vmovsh and are deleted.

Even better.

>> Also, to avoid the need to touch the previously last line when adding new
>> enumerators, it is good practice to have a trailing comma.
>> Like e.g. ..
>>
>>> @@ -1102,6 +1119,47 @@ enum
>>>    PREFIX_EVEX_0F389B,
>>>    PREFIX_EVEX_0F38AA,
>>>    PREFIX_EVEX_0F38AB,
>>> +  PREFIX_EVEX_0F3A08_W_0,
>>
>> ... was the case here before your additions.
>>
> Ok, I added a blank line between them. Thanks.

I'm afraid I don't follow - I did ask for maintaining a trailing
comma on the last enumerator of an enumeration.

Jan



More information about the Binutils mailing list