Maybe another or1k bug

[Richard Henderson]

On 7/7/21 2:06 PM, Stafford Horne wrote:
> +CC Richards other account
> 
> Hi Richard,
> 
> I Cced this to you twiddle.net account you on this one originally. Do you recall
> why we added the below check in or1k bfd?  It seems to be overly restrictive and
> causing some issues below.
> 
>   case R_OR1K_INSN_REL_26:
>     if (bfd_link_pic (info) && !SYMBOL_REFERENCES_LOCAL (info, h))
>       ERROR
...
>> 4. The symbols are from `readelf -s`:
>>
>>     221: 00008ce4   716 FUNC    GLOBAL PROTECTED   24 alSourcePausev
>>     222: 00008fb0    36 FUNC    GLOBAL PROTECTED   24 alSourcePause
>>     223: 00008fd4   784 FUNC    GLOBAL PROTECTED   24 alSourceStopv
>>     224: 000092e4    36 FUNC    GLOBAL PROTECTED   24 alSourceStop
>>     225: 00009308   720 FUNC    GLOBAL PROTECTED   24 alSourceRewindv
>>     226: 000095d8    36 FUNC    GLOBAL PROTECTED   24 alSourceRewind

Ah, STV_PROTECTED.  Unusual.

It looks like this should be SYMBOL_CALLS_LOCAL.  The only difference from 
SYMBOL_REFERENCES_LOCAL is versus protected symbols.


r~