gas testsuite tidy
Alan Modra
amodra@gmail.com
Tue Jan 26 10:28:31 GMT 2021
This replaces skip and notarget in a number of gas tests with xfail,
the idea being that running tests might expose segmentation faults or
other serious errors even when we don't expect a test to pass. Doing
so showed a number of cases where tests now pass, which is another
reason to avoid profligate use of notarget and skip.
* testsuite/gas/all/local-label-overflow.d: Use xfail rather than
notarget all except hppa. Comment.
* testsuite/gas/all/sleb128-2.d: Use xfail rather than notarget.
* testsuite/gas/all/sleb128-4.d: Likewise. Don't skip msp430.
* testsuite/gas/all/sleb128-5.d: Use xfail rather than notarget.
* testsuite/gas/all/sleb128-7.d: Likewise.
* testsuite/gas/all/sleb128-9.d: Likewise.
* testsuite/gas/elf/bignums.d: Likewise.
* testsuite/gas/elf/group0c.d: Likewise.
* testsuite/gas/elf/group1a.d: Likewise.
* testsuite/gas/elf/section-symbol-redef.d: Likewise.
* testsuite/gas/elf/section15.d: Likewise.
* testsuite/gas/elf/section4.d: Likewise.
* testsuite/gas/elf/section7.d: Likewise.
* testsuite/gas/macros/irp.d: Likewise.
* testsuite/gas/macros/repeat.d: Likewise.
* testsuite/gas/macros/rept.d: Likewise.
* testsuite/gas/macros/test2.d: Likewise.
* testsuite/gas/macros/vararg.d: Likewise.
* testsuite/gas/all/string.d: Use xfail rather than skip.
* testsuite/gas/elf/missing-build-notes.d: Likewise.
* testsuite/gas/elf/section0.d: Likewise.
* testsuite/gas/elf/section1.d: Likewise.
* testsuite/gas/elf/section10.d: Likewise.
* testsuite/gas/elf/section11.d: Likewise.
* testsuite/gas/elf/section6.d: Likewise.
* testsuite/gas/elf/symtab.d: Use xfail rather than skip, adjust hppa.
* testsuite/gas/elf/symtab.s: Don't start directives in first column.
* testsuite/gas/macros/test3.d: Don't notarget nds32.
diff --git a/gas/testsuite/gas/all/local-label-overflow.d b/gas/testsuite/gas/all/local-label-overflow.d
index 956025c5767..e0895daa3e5 100644
--- a/gas/testsuite/gas/all/local-label-overflow.d
+++ b/gas/testsuite/gas/all/local-label-overflow.d
@@ -1,3 +1,6 @@
#source: local-label-overflow.s
#error_output: local-label-overflow.l
-#notarget: hppa*-*-* ia64-*-vms mmix-*-* sh-*-pe
+# Some hppa targets support local labels, others don't. It's a pain to
+# enumerate all the combinations so just don't run the test for hppa.
+#notarget: hppa*-*-*
+#xfail: ia64-*-vms mmix-*-* sh-*-pe
diff --git a/gas/testsuite/gas/all/sleb128-2.d b/gas/testsuite/gas/all/sleb128-2.d
index df24fafb5e9..da335e57312 100644
--- a/gas/testsuite/gas/all/sleb128-2.d
+++ b/gas/testsuite/gas/all/sleb128-2.d
@@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been
# performed.
-#notarget : riscv*-*-*
+#xfail: riscv*-*-*
.*: .*
diff --git a/gas/testsuite/gas/all/sleb128-4.d b/gas/testsuite/gas/all/sleb128-4.d
index a0207411050..4cdfe9c484b 100644
--- a/gas/testsuite/gas/all/sleb128-4.d
+++ b/gas/testsuite/gas/all/sleb128-4.d
@@ -1,10 +1,9 @@
#objdump : -s -j .data -j "\$DATA\$"
#name : .sleb128 tests (4)
-#skip: msp430*-*-*
# RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been
# performed.
-#notarget: riscv*-*-*
+#xfail: riscv*-*-*
.*: .*
diff --git a/gas/testsuite/gas/all/sleb128-5.d b/gas/testsuite/gas/all/sleb128-5.d
index d6d4e376668..3ee3cea8717 100644
--- a/gas/testsuite/gas/all/sleb128-5.d
+++ b/gas/testsuite/gas/all/sleb128-5.d
@@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been
# performed.
-#notarget : riscv*-*-*
+#xfail: riscv*-*-*
.*: .*
diff --git a/gas/testsuite/gas/all/sleb128-7.d b/gas/testsuite/gas/all/sleb128-7.d
index 609088bdddd..8a4258bc1db 100644
--- a/gas/testsuite/gas/all/sleb128-7.d
+++ b/gas/testsuite/gas/all/sleb128-7.d
@@ -3,7 +3,7 @@
# RISC-V doesn't support .sleb operands that are the difference of two symbols
# because symbol values are not known until after linker relaxation has been
# performed.
-#notarget: riscv*-*-*
+#xfail: riscv*-*-*
.*: .*
diff --git a/gas/testsuite/gas/all/sleb128-9.d b/gas/testsuite/gas/all/sleb128-9.d
index 13d30d1b9f0..abfe2f3f2b2 100644
--- a/gas/testsuite/gas/all/sleb128-9.d
+++ b/gas/testsuite/gas/all/sleb128-9.d
@@ -1,5 +1,5 @@
#name: undefined symbols in sleb128 directive
#source: sleb128-9.s
#error_output: sleb128-9.l
-#notarget: riscv*-*
+#xfail: riscv*-*
diff --git a/gas/testsuite/gas/all/string.d b/gas/testsuite/gas/all/string.d
index 5408ab03ff5..ada28e2534b 100644
--- a/gas/testsuite/gas/all/string.d
+++ b/gas/testsuite/gas/all/string.d
@@ -1,6 +1,6 @@
#objdump : -s -j .data -j "\$DATA\$"
#name : .strings tests
-#skip: tic4x-*
+#xfail: tic4x-*
.*: .*
diff --git a/gas/testsuite/gas/elf/bignums.d b/gas/testsuite/gas/elf/bignums.d
index 1cc50aaea50..3c05470f708 100644
--- a/gas/testsuite/gas/elf/bignums.d
+++ b/gas/testsuite/gas/elf/bignums.d
@@ -1,6 +1,6 @@
#readelf: -x .data
#name: bignum byte values
-#notarget: rx-*
+#xfail: rx-*
# The RX target sometimes calls its data section D_1.
#
# Test that 8-bit and 16-bit constants can be specified via bignums.
diff --git a/gas/testsuite/gas/elf/group0c.d b/gas/testsuite/gas/elf/group0c.d
index 9564f65cedc..ffb129a6ca7 100644
--- a/gas/testsuite/gas/elf/group0c.d
+++ b/gas/testsuite/gas/elf/group0c.d
@@ -1,7 +1,7 @@
#readelf: -sW
#name: group section name
#source: group0.s
-#notarget: *-*-solaris*
+#xfail: *-*-solaris*
#...
.*NOTYPE[ ]+LOCAL[ ]+DEFAULT[ ]+[0-9]+[ ]+\.foo_group
diff --git a/gas/testsuite/gas/elf/group1a.d b/gas/testsuite/gas/elf/group1a.d
index d5f7fecd88c..b40d5ddbf90 100644
--- a/gas/testsuite/gas/elf/group1a.d
+++ b/gas/testsuite/gas/elf/group1a.d
@@ -2,7 +2,7 @@
#name: group section with multiple sections of same name (using readelf -SW)
#source: group1.s
# The RX port uses non-standard section names.
-#notarget: rx-*
+#xfail: rx-*
#...
[ ]*\[.*\][ ]+\.group[ ]+GROUP.*
diff --git a/gas/testsuite/gas/elf/missing-build-notes.d b/gas/testsuite/gas/elf/missing-build-notes.d
index 1d3efbbba05..0cfb11024dd 100644
--- a/gas/testsuite/gas/elf/missing-build-notes.d
+++ b/gas/testsuite/gas/elf/missing-build-notes.d
@@ -1,6 +1,6 @@
# as: --generate-missing-build-notes=yes
# objdump: -r
-#skip: mips*-*-openbsd
+#xfail: mips*-*-openbsd
# Check that the relocations are for increasing addresses...
diff --git a/gas/testsuite/gas/elf/section-symbol-redef.d b/gas/testsuite/gas/elf/section-symbol-redef.d
index 2ce245246f8..149e8f9de64 100644
--- a/gas/testsuite/gas/elf/section-symbol-redef.d
+++ b/gas/testsuite/gas/elf/section-symbol-redef.d
@@ -1,5 +1,5 @@
#readelf: -x myseg
-#notarget: bfin-*-* h8300-*
+#xfail: bfin-*-* h8300-*
Hex dump of section .*:
0x0+ 2a\s+\*
diff --git a/gas/testsuite/gas/elf/section0.d b/gas/testsuite/gas/elf/section0.d
index be1d547d5ed..0d9cb177d57 100644
--- a/gas/testsuite/gas/elf/section0.d
+++ b/gas/testsuite/gas/elf/section0.d
@@ -2,7 +2,7 @@
#name: elf section0
# The h8300 port issues a warning message for
# new sections created without atrributes.
-#skip: h8300-*
+#xfail: h8300-*
.*: +file format .*
diff --git a/gas/testsuite/gas/elf/section1.d b/gas/testsuite/gas/elf/section1.d
index b02a9e427e9..f0c2eb501af 100644
--- a/gas/testsuite/gas/elf/section1.d
+++ b/gas/testsuite/gas/elf/section1.d
@@ -2,7 +2,7 @@
#name: elf section1
# The h8300 port issues a warning message for
# new sections created without atrributes.
-#skip: h8300-*
+#xfail: h8300-*
.*: +file format .*
diff --git a/gas/testsuite/gas/elf/section10.d b/gas/testsuite/gas/elf/section10.d
index 6aa7b088b1b..d51bd4e36e5 100644
--- a/gas/testsuite/gas/elf/section10.d
+++ b/gas/testsuite/gas/elf/section10.d
@@ -1,7 +1,7 @@
#readelf: -N --wide
#name: numeric section flags and types
# The RX port annoyingly reorders the sections so that they do not match the sequence expected below.
-#skip: rx-*-*
+#xfail: rx-*-*
#...
[ ]*\[.*\][ ]+.text
diff --git a/gas/testsuite/gas/elf/section11.d b/gas/testsuite/gas/elf/section11.d
index 4cada2a7fee..427aea67032 100644
--- a/gas/testsuite/gas/elf/section11.d
+++ b/gas/testsuite/gas/elf/section11.d
@@ -2,10 +2,10 @@
#readelf: -S --wide
#name: Disabling section padding
# The RX port uses non standard section names.
-#skip: rx-*-*
+#xfail: rx-*-*
# RISC-V handles alignment via linker relaxation, so object files don't have
# the expected alignment.
-#notarget: riscv*-*-*
+#xfail: riscv*-*-*
#...
\[ .\] .text[ ]+PROGBITS[ ]+0+00 0+[0-9a-f]+ 0+0(1|4|5) 00 AX 0 0 16
diff --git a/gas/testsuite/gas/elf/section15.d b/gas/testsuite/gas/elf/section15.d
index a7cda1394f4..c576e44abbc 100644
--- a/gas/testsuite/gas/elf/section15.d
+++ b/gas/testsuite/gas/elf/section15.d
@@ -2,7 +2,7 @@
#name: elf section15
# .pushsection always creates the named section, but the
# test harness translates ".text" into "P" for the RX...
-#notarget: rx-*
+#xfail: rx-*
.*: +file format .*
diff --git a/gas/testsuite/gas/elf/section4.d b/gas/testsuite/gas/elf/section4.d
index fbeb0c7d595..bb13d2b7c60 100644
--- a/gas/testsuite/gas/elf/section4.d
+++ b/gas/testsuite/gas/elf/section4.d
@@ -1,7 +1,7 @@
#readelf: --sections
#name: label arithmetic with multiple same-name sections
# The RX port uses non-standard section names.
-#notarget: rx-*
+#xfail: rx-*
#...
[ ]*\[.*\][ ]+\.group[ ]+GROUP.*
diff --git a/gas/testsuite/gas/elf/section6.d b/gas/testsuite/gas/elf/section6.d
index c42d95c2aa3..4e5c2bffa08 100644
--- a/gas/testsuite/gas/elf/section6.d
+++ b/gas/testsuite/gas/elf/section6.d
@@ -2,7 +2,7 @@
#name: elf section6
# The h8300 port issues a warning message for
# new sections created without atrributes.
-#skip: h8300-*
+#xfail: h8300-*
.*: +file format .*
diff --git a/gas/testsuite/gas/elf/section7.d b/gas/testsuite/gas/elf/section7.d
index c424a0fdfbd..558500c9700 100644
--- a/gas/testsuite/gas/elf/section7.d
+++ b/gas/testsuite/gas/elf/section7.d
@@ -2,7 +2,7 @@
#name: elf section7
# .pushsection always creates the named section, but the
# test harness translates ".text" into "P" for the RX...
-#notarget: rx-*
+#xfail: rx-*
.*: +file format .*
diff --git a/gas/testsuite/gas/elf/symtab.d b/gas/testsuite/gas/elf/symtab.d
index ce8d165072f..68e5e7ca33e 100644
--- a/gas/testsuite/gas/elf/symtab.d
+++ b/gas/testsuite/gas/elf/symtab.d
@@ -1,6 +1,6 @@
# The Alpha has its own version of .set.
-# The HPPA does not output non-global absolute symbols.
-#skip: alpha-*-* hppa*-*-*
+# hppa SOM does not output non-global absolute symbols.
+#xfail: alpha-*-* [is_som_format]
#readelf: -s
#name: .set with expression
diff --git a/gas/testsuite/gas/elf/symtab.s b/gas/testsuite/gas/elf/symtab.s
index 9219cf88098..235cf8db5bb 100644
--- a/gas/testsuite/gas/elf/symtab.s
+++ b/gas/testsuite/gas/elf/symtab.s
@@ -1,4 +1,4 @@
-.text
+ .text
.global foo
foo:
.set shift, 32
diff --git a/gas/testsuite/gas/macros/irp.d b/gas/testsuite/gas/macros/irp.d
index 4b69658d573..fd98b60cc80 100644
--- a/gas/testsuite/gas/macros/irp.d
+++ b/gas/testsuite/gas/macros/irp.d
@@ -1,7 +1,7 @@
#objdump: -r
#name: macro irp
#darwin (mach-o) reverses relocs.
-#notarget: *-*-darwin* nds32*-*-*
+#xfail: *-*-darwin* nds32*-*-*
.*: +file format .*
diff --git a/gas/testsuite/gas/macros/repeat.d b/gas/testsuite/gas/macros/repeat.d
index 68f2db9ade8..8f3bdcf535c 100644
--- a/gas/testsuite/gas/macros/repeat.d
+++ b/gas/testsuite/gas/macros/repeat.d
@@ -1,7 +1,7 @@
#objdump: -r
#name: nested irp/irpc/rept
# darwin (mach-o) reverse relocs.
-#notarget: *-*-darwin*
+#xfail: *-*-darwin*
.*: +file format .*
diff --git a/gas/testsuite/gas/macros/rept.d b/gas/testsuite/gas/macros/rept.d
index 2fb4465ccb3..73223490e4f 100644
--- a/gas/testsuite/gas/macros/rept.d
+++ b/gas/testsuite/gas/macros/rept.d
@@ -1,7 +1,7 @@
#objdump: -r
#name: macro rept
#darwin (mach-o) reverses relocs.
-#notarget: *-*-darwin* nds32*-*-*
+#xfail: *-*-darwin* nds32*-*-*
.*: +file format .*
diff --git a/gas/testsuite/gas/macros/test2.d b/gas/testsuite/gas/macros/test2.d
index adb0eed810a..08ba703ddd5 100644
--- a/gas/testsuite/gas/macros/test2.d
+++ b/gas/testsuite/gas/macros/test2.d
@@ -1,7 +1,7 @@
#objdump: -r
#name: macro test 2
# darwin(mach-o) reverses the order of relocs.
-#notarget: *-*-darwin*
+#xfail: *-*-darwin*
.*: +file format .*
diff --git a/gas/testsuite/gas/macros/test3.d b/gas/testsuite/gas/macros/test3.d
index 6a1df31efec..054cf233074 100644
--- a/gas/testsuite/gas/macros/test3.d
+++ b/gas/testsuite/gas/macros/test3.d
@@ -1,6 +1,5 @@
#objdump: -r
#name: macro test 3
-#notarget: nds32*-*-*
.*: +file format .*
diff --git a/gas/testsuite/gas/macros/vararg.d b/gas/testsuite/gas/macros/vararg.d
index ff633bd33e8..f566eae4356 100644
--- a/gas/testsuite/gas/macros/vararg.d
+++ b/gas/testsuite/gas/macros/vararg.d
@@ -1,7 +1,7 @@
#objdump: -r
#name: macro vararg
# darwin (mach-o) reverses relocs.
-#notarget: *-*-darwin*
+#xfail: *-*-darwin*
.*: +file format .*
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list