[PATCH] bfin: Skip non SEC_ALLOC section for R_BFIN_FUNCDESC

[H.J. Lu]

On Thu, Jan 14, 2021 at 12:27 PM Mike Frysinger <vapier@gentoo.org> wrote:
>
> On 14 Jan 2021 05:28, H.J. Lu via Binutils wrote:
> > On Wed, Jan 13, 2021 at 10:00 PM Mike Frysinger wrote:
> > > On 13 Jan 2021 04:41, H.J. Lu via Binutils wrote:
> > > > Linker should never generate dynamic relocations for relocations in
> > > > non-SEC_ALLOC section which has no impact on run-time behavior.  Such
> > > > relocations should be resolved to 0.
> > >
> > > does elf32-frv.c need the same fix ?  kind of looks like it.
> >
> > Yes.  FRV maintainers need to take a look.
>
> well, didn't you merge this ? :)
>         frv: Don't generate dynamic relocation for non SEC_ALLOC sections
>
> > There are many code/bug duplications in FDPIC support.
> > They should be merged.
>
> to be fair, Blackfin copied FRV :).  we owe a ton to FRV wrt FDPIC in the
> toolchain & kernel.
>
> i took a look a while ago about trying to factor things out at least in
> gdb, but it got so invasive, and i didn't have FRV to verify against,
> that i ended up shelving it.
>
> i'd feel similarly about such large refactors in bfd.  not sure how to
> even structure it.  would we create files like fdpic.c/fdpic32.c ?
> -mike

Take a look at elfxx-x86.[ch] to see how I merged common parts
of i386 and x86-64.

-- 
H.J.