[PATCH] bfin: Don't call bfd_elf_link_record_dynamic_symbol

H.J. Lu hjl.tools@gmail.com
Sat Jan 9 14:22:23 GMT 2021


On Fri, Jan 8, 2021 at 3:27 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi H.J.
>
> >> FAIL: ld-elf/pr26979a
> >> FAIL: ld-elf/pr26979b
> >> FAIL: Symbol export class test (final shared object)
> >>
> >>          * elf32-bfin.c (bfinfdpic_check_relocs): Don't call
> >>          bfd_elf_link_record_dynamic_symbol.
>
> I am no bfin expert, but the patch looks simple enough to me,
> and since no one else has objected, please considered it approved.
>

The patch is incorrect.  I checked in a different one:

commit d4e57b87a3d5879917c30e33b14760fd76ff7b38
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Dec 29 10:41:51 2020 -0800

    bfin: Check bfd_link_hash_indirect

    Add bfd_link_hash_indirect check to check_relocs.  This fixed:

    FAIL: ld-elf/pr26979a
    FAIL: ld-elf/pr26979b
    FAIL: Symbol export class test (final shared object)

            * elf32-bfin.c (bfin_check_relocs): Check bfd_link_hash_indirect.
            (bfinfdpic_check_relocs): Likewise.


-- 
H.J.


More information about the Binutils mailing list