[PATCH 00/13] CTF dumper improvements, a lookup testsuite, and bugfixes

[H.J. Lu]

On Tue, Jan 5, 2021 at 9:14 AM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> On 5 Jan 2021, H. J. Lu via Binutils said:
>
> > All libctf tests failed for cross binutils without a cross compiler:
> >
> > ERROR: aarch64-linux-cc does not exist
>
> Ugh. It helps to actually *call* check_compiler_available as well as
> just defining it. How did I miss that?
>
> Unusurprisingly since we never called it it was a crawling mass of bugs
> as well. :(
>
> Try this (not really tested yet since I don't have a non-libctf-capable
> compiler to hand right now, so I only know it works in the positive
> case!):
>
> If it works for you, I'll push it.
>
> Sorry about this.
>
> 8<----------------------------------------------->8
> From 70d3120f32281980105169dee74440146e97702e Mon Sep 17 00:00:00 2001
> From: Nick Alcock <nick.alcock@oracle.com>
> Date: Tue, 5 Jan 2021 17:11:20 +0000
> Subject: [PATCH] libctf, testsuite: don't run without a suitable compiler
>
> We never actually check to see if the compiler supports CTF,
> or even if a suitable compiler exists.
>
> libctf/ChangeLog
> 2021-01-05  Nick Alcock  <nick.alcock@oracle.com>
>
>         * Makefile.am (BASEDIR): New.
>         (BFDDIR): Likewise.
>         (check-DEJAGNU): Add development.exp to prerequisites.
>         (development.exp): New.
>         (CONFIG_STATUS_DEPENDENCIES): New.
>         (EXTRA_DEJAGNU_SITE_CONFIG): Likewise.
>         (DISTCLEANFILES): Likewise.
>         * Makefile.in: Regenerated.
>         * testsuite/lib/ctf-lib.exp (check_ctf_available): Return boolean.
>         * testsuite/libctf-lookup/lookup.exp: Call check_ctf_available.
>         * testsuite/libctf-regression/regression.exp: Likewise.
> ---
>  libctf/ChangeLog                                  | 14 ++++++++++++++
>  libctf/Makefile.am                                | 15 ++++++++++++++-
>  libctf/Makefile.in                                | 14 +++++++++++++-
>  libctf/testsuite/lib/ctf-lib.exp                  |  7 ++++++-
>  libctf/testsuite/libctf-lookup/lookup.exp         |  5 +++++
>  libctf/testsuite/libctf-regression/regression.exp |  5 +++++
>  6 files changed, 57 insertions(+), 3 deletions(-)
>
> diff --git a/libctf/ChangeLog b/libctf/ChangeLog
> index 0aaf3067ab6..0f5e96a2c83 100644
> --- a/libctf/ChangeLog
> +++ b/libctf/ChangeLog
> @@ -1,3 +1,17 @@
> +2021-01-05  Nick Alcock  <nick.alcock@oracle.com>
> +
> +       * Makefile.am (BASEDIR): New.
> +       (BFDDIR): Likewise.
> +       (check-DEJAGNU): Add development.exp to prerequisites.
> +       (development.exp): New.
> +       (CONFIG_STATUS_DEPENDENCIES): New.
> +       (EXTRA_DEJAGNU_SITE_CONFIG): Likewise.
> +       (DISTCLEANFILES): Likewise.
> +       * Makefile.in: Regenerated.
> +       * testsuite/lib/ctf-lib.exp (check_ctf_available): Return boolean.
> +       * testsuite/libctf-lookup/lookup.exp: Call check_ctf_available.
> +       * testsuite/libctf-regression/regression.exp: Likewise.
> +

Can you verify and check in the check_ctf_available change first to
unbreak cross binutils?

Thanks.

-- 
H.J.