[PATCH] bfd: add missing smclass when creating csect for xcoff64

CHIGOT, CLEMENT clement.chigot@atos.net
Tue Feb 23 09:02:58 GMT 2021


> OK, so the next question is whether you have a copyright assignment
> agreement with the FSF for the binutils project?  That is needed for
> non-trivial contributions to binutils.

No I don't have any and I didn't find the webpage explaining how
to proceed. Do you have it ?

> Also, I see
> +FAIL: XCOFF TOC reloc test 1
> +FAIL: PowerPC Test 1, 32 bit XCOFF
> in the gas testsuite and
> +FAIL: Object for --just-symbols test
> in the ld testsuite with your patches applied.
>
> The last one, a segmentation fault in your new code, is easy to fix.
> Didn't you run the testsuite?

It seems that I have missed them. As you might have seen, I've made
these patches two months ago and I don't remember them failing at
that time. I've rebased and checked quickly before opening this
discussion. I should have checked more, my bad...
Moreover, there is a lot of tests already failing in the testsuite
(not with gas actually). Thus, I'm "fixing" them in several other
patches. But I don't want to push them as I still don't know
the root cause.
I'll check your patch also.

Thanks,
Clément



More information about the Binutils mailing list