[PING][PATCH] binutils: Avoid renaming over existing files

Siddhesh Poyarekar siddhesh@gotplt.org
Tue Feb 23 02:23:32 GMT 2021


On 2/23/21 5:30 AM, Alan Modra wrote:
> On Mon, Feb 22, 2021 at 09:00:42PM +0530, Siddhesh Poyarekar wrote:
>> On 2/19/21 10:15 PM, Nick Clifton wrote:
>>> Hi Siddhesh,
>>>
>>>> I don't know.  Nick, Alan, should this be backported to 2.36?
>>>
>>> Yes please.
>>
>> Thanks, backported and pushed to binutils-2_36-branch.
> 
> See pr27456.  It seems to me that smart_rename now will always be
> copying the temp file contents to the output file in the non-windows
> case, and that we can make it do the same for windows too.  I'm
> testing the following.

Indeed, I had forgotten that an empty output file always gets created.

Thanks,
Siddhesh


More information about the Binutils mailing list