Fail run_dump_test when an error is expected but not seen

Alan Modra amodra@gmail.com
Sat Feb 20 07:59:29 GMT 2021


This is a -w diff.

	* testsuite/lib/binutils-common.exp: Whitespace fixes throughout.
	(run_dump_test): Fail if expecting errors from a file like we do
	for error strings, if no error is seen.

diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 029284167a..59e25df99b 100644
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -1438,7 +1438,7 @@ proc run_dump_test { name {extra_options {}} } {
 	}
 
 	# We must not have expected failure if we get here.
-        if { $opts(error) != "" } {
+	if { $want_out(terminal) } {
 	    fail $testname
 	    continue
 	}

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list