[PING][PATCH] binutils: Avoid renaming over existing files

Matthias Klose doko@ubuntu.com
Fri Feb 19 07:44:51 GMT 2021


On 2/19/21 3:37 AM, Siddhesh Poyarekar wrote:
> On 2/19/21 12:50 AM, Nick Clifton wrote:
>> Hi Siddhesh,
>>
>> Sorry for the long delay in looking at this patch.
>>
>>>> binutils/
>>>>
>>>>     * ar.c (write_archive): Remove TARGET_STAT.  Adjust call to
>>>>     SMART_RENAME.
>>>>     * arsup.c (ar_save): Likewise.
>>>>     * objcopy (strip_main): Don't copy TMPFD.  Don't set times on
>>>>     temporary file and adjust call to SMART_RENAME.
>>>>     (copy_main): Likewise.
>>>>     * rename.c [!S_ISLNK]: Remove definitions.
>>>>     (try_preserve_permissions): Remove function.
>>>>     (smart_rename): Remove FD, PRESERVE_DATES arguments.  Use
>>>>     rename system call only if TO does not exist.
>>>>     * bucomm.h (smart_rename): Adjust declaration.
>>>> ---
>>
>> Approved - please apply.
> 
> Thanks, pushed.
> 
> Siddhesh

what's the plan for the 2.36 branch?

Matthias


More information about the Binutils mailing list