[PING][PATCH] binutils: Avoid renaming over existing files

Nick Clifton nickc@redhat.com
Thu Feb 18 19:20:03 GMT 2021


Hi Siddhesh,

Sorry for the long delay in looking at this patch.

>> binutils/
>>
>>     * ar.c (write_archive): Remove TARGET_STAT.  Adjust call to
>>     SMART_RENAME.
>>     * arsup.c (ar_save): Likewise.
>>     * objcopy (strip_main): Don't copy TMPFD.  Don't set times on
>>     temporary file and adjust call to SMART_RENAME.
>>     (copy_main): Likewise.
>>     * rename.c [!S_ISLNK]: Remove definitions.
>>     (try_preserve_permissions): Remove function.
>>     (smart_rename): Remove FD, PRESERVE_DATES arguments.  Use
>>     rename system call only if TO does not exist.
>>     * bucomm.h (smart_rename): Adjust declaration.
>> ---

Approved - please apply.

Cheers
   Nick



More information about the Binutils mailing list