[PATCH] RISC-V: Add bfd/cpu-riscv.h to support all spec versions controling.

Nelson Chu nelson.chu@sifive.com
Thu Feb 18 07:43:14 GMT 2021


Hi Nick and Jim,

Thanks for the reviews and approvals!  I have commited the v2 patch,
and also fixed some conflicts and typos.

On Thu, Feb 18, 2021 at 6:50 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Tue, Feb 16, 2021 at 6:05 PM Nelson Chu <nelson.chu@sifive.com> wrote:
>>
>> > diff --git a/bfd/doc/Makefile.in b/bfd/doc/Makefile.in
>> > index 1902697..129cadc 100644
>> > --- a/bfd/doc/Makefile.in
>> > +++ b/bfd/doc/Makefile.in
>> > @@ -377,6 +377,7 @@ pdfdir = @pdfdir@
>> >  prefix = @prefix@
>> >  program_transform_name = @program_transform_name@
>> >  psdir = @psdir@
>> > +runstatedir = @runstatedir@
>> >  sbindir = @sbindir@
>> >  sharedstatedir = @sharedstatedir@
>> >  srcdir = @srcdir@
>>
> FYI  This runstatedir stuff is a feature not in the last FSF autoconf release from 2012, but present in some linux distros.  To avoid this problem, you shouldn't use /usr/bin/autoconf or automake.  Rather, you should build them directly from FSF autoconf/automake sources, using the same version that is mentioned in the comments at the top of the generated files, and then use your own programs when regenerating toolchain files.  If you did that, then you wouldn't have a change for this file.  The same change would also be missing from other Makefile.in files.  But this is a minor issue, and will likely be fixed next time someone regenerates the files.
>
> The autoconf-2.69 we use was released in 2012.  There are now autoconf 2.70 (Dec 2020) and 2.71 (Jan 2021) releases.  If we upgraded to a newer autoconf release that would fix this problem.  Though of course it might cause other problems.  A lot of stuff could have changed in the last 9 years.

That's weird, even if I have switched to the approved versions of auto
tools (autoconf 2.69 and automake 1.15.1), I still get the
"runstatedir" in my Makefile.in.  I guess that is because I used to
regenerate the files by running autoconf and automake separately.
Kito suggests that using the "export PATH" to set the auto tools, and
then run autoreconf should be better.  After that, I can regenerate
the expected files without the "runstatedir".

Thanks for all
Nelson


More information about the Binutils mailing list