[PATCH] config/debuginfod: do not include pkg.m4 directly

Mike Frysinger vapier@gentoo.org
Sat Feb 13 05:17:10 GMT 2021


On 08 Feb 2021 12:39, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger via Binutils <binutils@sourceware.org> writes:
> 
> Mike> Any code using AC_DEBUGINFOD from this dir is using -I../config when
> Mike> running aclocal, so an explicit include on pkg.m4 is unnecessary:
> Mike> aclocal will find the pkg.m4 in this dir just as easily.  This is
> Mike> seen in the only two dirs that use AC_DEBUGINFOD (binutils & gdb)
> Mike> as their aclocal.m4 already has m4_include on config m4 files.
> 
> Mike> The include as written only works if aclocal is run on a dir that is
> 
> Mike> config/
> Mike> 	* debuginfod.m4: Delete m4_include(../config/pkg.m4).
> 
> Mike> binutils/
> Mike> 	* aclocal.m4: Regenerate.
> 
> Mike> gdb/
> Mike> 	* aclocal.m4: Regenerate.
> 
> This is fine by me, but please wait a little while in case someone on
> the binutils list has a differing opinion.

thanks, i've pushed now
-mike


More information about the Binutils mailing list