[PATCHv2 2/9] bfd/binutils: support for gdb target descriptions in the core file

[Jim Wilson]

On Wed, Jan 20, 2021 at 12:23 PM Andrew Burgess <andrew.burgess@embecosm.com>
wrote:

> bfd/ChangeLog:
>
>         * elf-bfd.h (elfcore_write_gdb_tdesc): Declare new function.
>         * elf.c (elfcore_grok_gdb_tdesc): New function.
>         (elfcore_grok_note): Handle NT_GDB_TDESC.
>         (elfcore_write_gdb_tdesc): New function.
>         (elfcore_write_register_note): Handle NT_GDB_TDESC.
>
> binutils/ChangeLog:
>
>         * readelf.c (get_note_type): Handle NT_GDB_TDESC.
>
> include/ChangeLog:
>
>         * elf/common.h (NT_GDB_TDESC): Define.
>

This looks OK.

Technically, new functions are supposed to have explanatory comments before
them, but there are others missing comments.  If you could add the missing
comments to the new functions in your patch that would be nice.

Jim