[PATCH 1/2] libctf, testsuite: don't run without a suitable compiler

[Jan Beulich]

On 05.01.2021 20:52, Nick Alcock via Binutils wrote:
> We never actually check to see if the compiler supports CTF,
> or even if a suitable compiler exists.
> 
> libctf/ChangeLog
> 2021-01-05  Nick Alcock  <nick.alcock@oracle.com>
> 
> 	* Makefile.am (BASEDIR): New.
> 	(BFDDIR): Likewise.
> 	(check-DEJAGNU): Add development.exp to prerequisites.
> 	(development.exp): New.
> 	(CONFIG_STATUS_DEPENDENCIES): New.
> 	(EXTRA_DEJAGNU_SITE_CONFIG): Likewise.
> 	(DISTCLEANFILES): Likewise.
> 	* Makefile.in: Regenerated.
> 	* testsuite/lib/ctf-lib.exp (check_ctf_available): Return boolean.
> 	* testsuite/libctf-lookup/lookup.exp: Call check_ctf_available.
> 	* testsuite/libctf-regression/regression.exp: Likewise.

Is there any reason the same check didn't get added here to
testsuite/libctf-writable/writable.exp? If it was there, on an
older host I expect I wouldn't have run into

ERROR: (DejaGnu) proc "try {
	set run_output [exec "sh" "-c" "$command" "2>@1"]
	set status 0
    } trap CHILDSTATUS {results options} {
	set status [lindex [dict get $options -errorcode] 2]
	set run_output $results
    }" does not exist.
The error code is CHILDSTATUS 22593 1
The info on the error is:
child process exited abnormally
    while executing
"close file7"
    invoked from within
"catch "close $id" res"

because the Tcl there is 8.5, but "try" is available only
from 8.6. I think this dependency would also be nice to be
checked.

Jan