[PATCH] opcodes/i386-dis.c is not thread-safe

Vladimir Mezentsev vladimir.mezentsev@oracle.com
Fri Dec 17 23:23:41 GMT 2021



On 12/16/21 23:24, Jan Beulich wrote:
> On 16.12.2021 23:26, Vladimir Mezentsev via Binutils wrote:
>> From: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
>>
>> We plan to use print_insn_i386_att, print_insn_i386_intel and
>> print_insn_i386 in a multithreaded application.
>> These functions are not thread safe due to the use of static variables.
>>
>> A disassembly output is changed due to fixes in swap_operand().
>> The old swap_operand() did not cleanup mnemonicendp.
>>
>> Tested on x86_64-pc-linux-gnu.
> Looks plausible at the first glance, but it would be quite helpful if this
> was split up some. At the very least the fix to swap_operand() should be
> a separate prereq change, imo.

  Hi Jan,

Thank you for review.
It is a good suggestion.
I will prepare a separate fix only in swap_operand().

Thank you,
-Vladimir

>
> Jan
>



More information about the Binutils mailing list