[RFC 4/4] RISC-V: fix a comment for adding CSR entry and annotate switch-break
Palmer Dabbelt
palmer@dabbelt.com
Fri Dec 17 04:10:54 GMT 2021
On Thu, 16 Dec 2021 09:33:28 PST (-0800), Vineet Gupta wrote:
> Nothing functional ...
>
> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
> ---
> gas/config/tc-riscv.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gas/config/tc-riscv.c b/gas/config/tc-riscv.c
> index e28818b4fd15..082dc59aa9f9 100644
> --- a/gas/config/tc-riscv.c
> +++ b/gas/config/tc-riscv.c
> @@ -83,7 +83,7 @@ struct riscv_csr_extra
> enum riscv_spec_class define_version;
>
> /* Record the CSR is aborted/invalid from which versions. If it isn't
> - aborted in the current version, then it should be CSR_CLASS_VDRAFT. */
> + aborted in the current version, then it should be PRIV_SPEC_CLASS_DRAFT. */
> enum riscv_spec_class abort_version;
>
> /* The CSR may have more than one setting. */
> @@ -1109,7 +1109,7 @@ validate_riscv_insn (const struct riscv_opcode *opc, int length)
> default:
> goto unknown_validate_operand;
> }
> - break;
> + break; /* end RVC */
> case 'V': /* RVV */
> switch (*++oparg)
> {
> @@ -1133,7 +1133,7 @@ validate_riscv_insn (const struct riscv_opcode *opc, int length)
> default:
> goto unknown_validate_operand;
> }
> - break;
> + break; /* end RVV */
> case ',': break;
> case '(': break;
> case ')': break;
> @@ -2610,7 +2610,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr,
> default:
> goto unknown_riscv_ip_operand;
> }
> - break;
> + break; /* end RVC */
>
> case 'V': /* RVV */
> switch (*++oparg)
> @@ -2776,7 +2776,7 @@ riscv_ip (char *str, struct riscv_cl_insn *ip, expressionS *imm_expr,
> default:
> goto unknown_riscv_ip_operand;
> }
> - break;
> + break; /* end RVV */
>
> case ',':
> ++argnum;
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
More information about the Binutils
mailing list