Oracle library fix

[Alan Modra]

On Fri, Dec 10, 2021 at 06:26:13PM +0100, Jose E. Marchesi wrote:
> 
> Hi Alan.
> 
> >> Does anyone know whether the following 1995 code is still needed?
> >> My guess is that the "incomprehensible reason" mentioned in the
> >> comment is that some object had relocation sections created by hand.
> >> With my recent commit b6d1f70cc7e any such relocation section should
> >> have a proper sh_link field, but of course if people are still using
> >> constructs like
> >>
> >>  .section .rel.text,""
> >>  .4byte reloc_offset
> >>  .4byte reloc_number + sym_index
> >>
> >> then I'll need to delay this cleanup for some years.
> >
> > I just asked internally about this.
> > Will let you know what I find out.
> 
> These are the findings:
> 
> As for Sun's compilers, assemblers and linkers, we have never heard of
> that.  The Solaris linkers don't contain any code like that.
> 
> As for Oracle Database, we are not aware of shipping objects with
> relocation sections having incorrect sh_link or using hand-crafted
> relocation sections.
> 
> It would be interesting to know what objects triggered the need for the
> workaround, but being the hack so old we will probably never know.
> 
> All in all, I would say it is perfectly ok to remove that code.
> Hope this is helpful.

Very helpful, thanks for doing this.  I've run
 grep '\.section[ 	"]*\.rel'
over a number of projects myself, so I'll now commit the cleanup.

-- 
Alan Modra
Australia Development Lab, IBM