[PATCH] readelf: recognize FDO Packaging Metadata ELF note

Luca Boccassi luca.boccassi@gmail.com
Wed Dec 1 15:47:14 GMT 2021


On Wed, 2021-12-01 at 14:45 +0000, Nick Clifton wrote:
> Hi Luca,
> 
> > > Approved - please apply.
> 
> (That was a hint to suggest that you could apply the patch yourself).

Oh sorry, didn't get that - but I'm not a maintainer so I don't think I
can do that?

> > Thank you - any update on committing it?
> 
> Done. :-)

Thank you!

But looks like there was some fuzz or something like that? One part got
applied in the wrong section - from the original email:

@@ -19197,6 +19197,8 @@ get_note_type (Filedata * filedata, unsigned e_type)
 	return _("func");
       case NT_GO_BUILDID:
 	return _("GO BUILDID");
+      case FDO_PACKAGING_METADATA:
+	return _("FDO_PACKAGING_METADATA");
       default:
 	break;
       }

Applied:

@@ -19220,6 +19220,8 @@ get_note_type (Filedata * filedata, unsigned e_type)
        return _("NT_SIGINFO (siginfo_t data)");
       case NT_FILE:
        return _("NT_FILE (mapped files)");
+      case FDO_PACKAGING_METADATA:
+       return _("FDO_PACKAGING_METADATA");
       default:
        break;
       }

But the latter doesn't work, as it's for ELF exec/libs rather than
corefiles:

    Displaying notes found in: .note.package
      Owner                Data size        Description
      FDO                  0x00000039       Unknown note type: (0xcafe1a7e)
        Packaging Metadata: {"type":"deb","name":"fsverity-utils","version":"1.3-1"}


But it's an easy fix, sent a follow-up:

https://sourceware.org/pipermail/binutils/2021-December/118746.html

-- 
Kind regards,
Luca Boccassi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://sourceware.org/pipermail/binutils/attachments/20211201/ecca9234/attachment.sig>


More information about the Binutils mailing list