Ping: [PATCH 00/11] gas: adjustments to floating point data directives handling

Alan Modra amodra@gmail.com
Thu Aug 12 07:29:52 GMT 2021


On Wed, Aug 11, 2021 at 08:47:20AM +0200, Jan Beulich wrote:
> I can repro any breakage, I'm certainly promising to try to take
> care of any such further issues with the series.

I'll take care of this one.  Fixes tic4x-coff FAIL: simple FP constants

	* testsuite/gas/all/float.s: Make NaN tests conditional on hasnan.
	* testsuite/gas/all/gas.exp: Define hasnan.

diff --git a/gas/testsuite/gas/all/float.s b/gas/testsuite/gas/all/float.s
index f401ed31a84..a84222cb0fb 100644
--- a/gas/testsuite/gas/all/float.s
+++ b/gas/testsuite/gas/all/float.s
@@ -8,9 +8,11 @@ foo:	.single	0r1.2345e+06
 	.dc.s 1
 	.dc.s 0f:1234
 	.dc.s Inf
+ .ifdef hasnan
 	.dc.s NaN
 	.dc.s QNaN
 	.dc.s SNaN
+ .endif
 	.dcb.s 1
 	.dcb.s 1, 1
 	.dcb.s 1, 0s:4321
@@ -19,9 +21,11 @@ foo:	.single	0r1.2345e+06
 	.dc.d 1
 	.dc.d 0d:1234
 	.dc.d +Inf
+ .ifdef hasnan
 	.dc.d -NaN
 	.dc.d +QNaN
 	.dc.d -SNaN
+ .endif
 	.dcb.d 1
 	.dcb.d 1, 1
 	.dcb.d 1, 0r:4321
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 389634f6165..e490d1f20ab 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -45,7 +45,12 @@ if { [istarget hppa*-*-*] || [istarget *c54x*-*-*] || [istarget mep*-*-*]} then
 # No floating point support in assembly code for CRIS and Z80.
 if { ![istarget cris-*-*] && ![istarget crisv32-*-*] 
      && ![istarget z80-*-*] } then {
-    gas_test "float.s" ""   "" "simple FP constants"
+    if { [istarget tic4x-*-*] } then {
+	set as_opt ""
+    } else {
+	set as_opt "--defsym hasnan=1"
+    }
+    gas_test "float.s" $as_opt "" "simple FP constants"
 }
 
 # This test is meaningless for the PA; the difference of two undefined


-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list