[PATCH] bfd: harmonize and improve auxiliary entries support for XCOFF

Nick Clifton nickc@redhat.com
Thu Apr 22 11:29:37 GMT 2021


Hi Clement.

   This patch fails to compile as it generates an error message like this:

   bfd/coff64-rs6000.c: In function '_bfd_xcoff64_swap_aux_in':
   bfd/coff64-rs6000.c:384:19: error: comparison is always true due to
   limited range of data type [-Werror=type-limits]

Changing auxtype from "char" to "unsigned char" fixes this.  (I am 
compiling with gcc v10, but the error also shows up with clang v10).

> bfd/ChangeLog:
> 2021-04-21  Clément Chigot  <clement.chigot@atos.net>
> 
> 	* coff-rs6000.c (_bfd_xcoff_swap_aux_in): Add errors for
> 	unsupported storage class or auxialiry entries.
> 	Improve and adapt to new aux structures.
> 	Add C_DWARF support.
> 	(_bfd_xcoff_swap_aux_out): Likewise.
> 	* coff64-rs6000.c (_bfd_xcoff64_swap_aux_in): Likewise.
> 	(_bfd_xcoff64_swap_aux_out): Likewise.
> 
> binutils/ChangeLog:
> 2021-04-21  Clément Chigot  <clement.chigot@atos.net>
> 
> 	* od-xcoff.c (dump_xcoff32_symbols): Adapt to new
> 	aux structures.
> 
> include/ChangeLog:
> 2021-04-21  Clément Chigot  <clement.chigot@atos.net>
> 
> 	* coff/internal.h (union internal_auxent):
> 	 Add x_sect structure.
> 	* coff/rs6000.h (union external_auxent): Rework to
> 	match official documentation.
> 	* coff/rs6k64.h (union external_auxent): Likewise.
> 	(_AUX_SECT): New define.

Approved and applied, with the change described above added.

Cheers
   Nick



More information about the Binutils mailing list