Ping: [PATCH] arm64: add two initializers
Jan Beulich
jbeulich@suse.com
Mon Apr 19 11:31:55 GMT 2021
On 22.03.2021 09:32, Jan Beulich via Binutils wrote:
> Old enough gcc can't cope and would warn about the variables potentially
> remaining uninitialized.
>
> opcodes/
> 2021-03-XX Jan Beulich <jbeulich@suse.com>
>
> * aarch64-asm.c (encode_asimd_fcvt): Add initializer for
> "qualifier".
> (convert_mov_to_movewide): Add initializer for "value".
As I'm unconvinced that such a change can really be considered trivial,
may I ask for an okay or otherwise?
Thanks, Jan
> --- a/opcodes/aarch64-asm.c
> +++ b/opcodes/aarch64-asm.c
> @@ -1335,7 +1335,7 @@ encode_asimd_fcvt (aarch64_inst *inst)
> {
> aarch64_insn value;
> aarch64_field field = {0, 0};
> - enum aarch64_opnd_qualifier qualifier;
> + enum aarch64_opnd_qualifier qualifier = AARCH64_OPND_QLF_NIL;
>
> switch (inst->opcode->op)
> {
> @@ -1893,7 +1893,7 @@ convert_mov_to_movewide (aarch64_inst *i
> {
> int is32;
> uint32_t shift_amount;
> - uint64_t value;
> + uint64_t value = ~(uint64_t)0;
>
> switch (inst->opcode->op)
> {
>
More information about the Binutils
mailing list