[PATCH 2/3] Sync libiberty and include with GCC for get_DW_UT_name.

Mark Wielaard mark@klomp.org
Thu Sep 24 21:12:49 GMT 2020


Hi Nick,

On Thu, Sep 24, 2020 at 11:26:42AM +0100, Nick Clifton wrote:
> > include/ChangeLog:
> > 
> > 	* dwarf2.def: Add DWARF5 Unit type header encoding macros
> > 	DW_UT_FIRST, DW_UT and DW_UT_END.
> > 	* dwarf2.h (enum dwarf_unit_type): Removed and define using
> > 	DW_UT_FIRST, DW_UT and DW_UT_END macros.
> > 	(get_DW_UT_name): New function declaration.
> > 
> > libiberty/ChangeLog:
> > 
> > 	* dwarfnames.c (get_DW_UT_name): Define using DW_UT_FIRST, DW_UT
> > 	and DW_UT_END.
>  
> Approved - please apply.  Note the convention with libiberty/ChangeLog 
> entries is to say "Sync with GCC" and then provide a copy of gcc's
> libiberty changelog entry.

Sorry, I cheated a bit and had submitted the GCC change at the same
time as the binutils one and had forgotten to add the Sync with GCC to
the commit message Changelog (it was actually in the ChangeLog file
entry). The patch has been accepted for GCC now. I have added the same
Sync with GCC to the commit message.

BTW. It would be nice if binutils adopted the same method as GCC and
only required the ChangeLog entries in the commit message and not
require an actual ChangeLog file entry.

Thanks,

Mark


More information about the Binutils mailing list