[PATCH] dependency list for static libraries
Nick Clifton
nickc@redhat.com
Wed Sep 23 11:52:29 GMT 2020
Hi Howard,
> Sorry for the noise, this attached is the same as previous but with fixes
> to whitespace / indentation.
Thanks - the patch looks good now, although there are still a couple of minor
issues - and one major issue:
* The new test fails for the alpha-vms target. This is not serious however
as almost all of the ar tests fail for this target. One day I will track
down what is going wrong and either fix it, or arrange to skip these tests
for alpha-vms.
* There are a couple of minor formatting issues. Specifically: comments should
end in a period followed by two spaces before the closing marker. /* Like this. */
Plus function calls should have a space between the function name and the
opening parenthesis of the argument list. like (this)
The major issue is that I would really like for this extension to be supported
by the LLVM community as well. It would be a shame to add it to the binutils
only to have a different solution implemented there. I might have misread the
emails but I believe that Fangrui still has some misgivings about this approach.
Is that correct ? If so, then I would very much like to see them resolved
before we commit the patch.
Cheers
Nick
More information about the Binutils
mailing list