Enable support to Intel Key locker instructions.

[Cui, Lili]

> On Tue, Sep 22, 2020 at 9:08 AM Jan Beulich <jbeulich@suse.com> wrote:
> > >> ... in this table you'll notice that MOD_0F38* all go together, and
> > >> _later_ there's a MOD_VEX_0F38* group. I notice that recent
> > >> additions (of yours?) also already violate this sorting model - please may
> I ask for this to corrected as well?
> > >> The more outliers we have there, the more difficult will it be to
> > >> maintain this code.
> > >
> > > Thank you reviewing my patch. I put MOD_VEX_0F38* together.
> >
> > Imo this should be a separate change, not merged into here.
> 
> Yes, please make a separate patch.
> 

Ok, I will fix it with a separate patch, thanks.

> > >> ... these four need special treatment in output_insn()'s setting of
> > >> GNU_PROPERTY_X86_FEATURE_2_XMM, due to the lack of explicit
> RegXMM
> > >> operands.
> > >>
> > > Added it.
> >
> > If I was making a change like this, I'm pretty sure H.J. would ask me
> > to also add test cases for it.
> >
> 
> Yes, please add a new testcase.  See:
> 
> commit a7e12755d57879884c523cae1cf009efc9da933c
> Author: H.J. Lu <hjl.tools@gmail.com>
> Date:   Wed Feb 19 04:54:45 2020 -0800
> 
>     x86: Mark cvtpi2ps and cvtpi2pd as MMX
> 
> for an example.
> 
> Thanks.
> 
> --
> H.J.

Added it, thanks.

Lili.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enable-support-to-Intel-Keylocker-instructions.patch
Type: application/octet-stream
Size: 26740 bytes
Desc: 0001-Enable-support-to-Intel-Keylocker-instructions.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20200923/601a2df6/attachment-0001.obj>