[PATCH] bpf: xBPF SDIV, SMOD instructions

Jose E. Marchesi jose.marchesi@oracle.com
Fri Sep 18 16:49:42 GMT 2020


Hi David.

>> Why not using define-alu-insn-bin and daib instead of defining an
>> additional pair of macros?  We can pass the ISAs as arguments to
>> daib/daiu and thus avoid replicating logic ...
>> 
>
> Long story short, I tried to do this originally but did it very poorly,
> and the result was not readable :)
>
> Revisiting today, I have realized what I was doing wrong. Here is a
> revised version of the patch following your suggestion to avoid the
> replicated logic.

Nice :)
This version LGTM.  Thanks!


More information about the Binutils mailing list