[PATCH] Add znver3 processor
Jan Beulich
jbeulich@suse.com
Wed Oct 21 07:18:01 GMT 2020
On 20.10.2020 20:47, Gopalasubramanian, Ganesh wrote:
>> Please submit the updated patch so that one can apply with "git am".
>
> PFA, the updated patch. Added "Word|Dword|Qword" for pvalidate. The test "snp.s" covers these operands in rAX.
Sorry, one more thing I notice only now:
> --- /dev/null
> +++ b/gas/testsuite/gas/i386/invlpgb64.d
> @@ -0,0 +1,16 @@
> +#as: --defsym __amd64__=1
We already have two mechanisms to allow for this distinction inside
source files - the legacy "--defsym x86_64=1" in i386.exp and the
more modern one not requiring any --defsym (see e.g. evex-no-scale.s).
While I realize there are other examples using a custom approach
(both __amd64__ and __64_bit__ can be found, and I didn't check
further), but I think new code would ideally stick to the modern
variant, but in no case should introduce further instances of custom
approaches. (I have on my TODO list the dropping of all --def-sym
uses for this purpose.)
Jan
More information about the Binutils
mailing list