[GOLD] Increase --split-stack-adjust-size

Ian Lance Taylor iant@google.com
Thu Oct 8 19:27:51 GMT 2020


On Wed, Oct 7, 2020 at 11:53 PM Alan Modra <amodra@gmail.com> wrote:
>
> For functions with small (< 256 bytes) stack frames, the current x86
> do_calls_non_split ignores --split-stack-adjust-size and, in
> combination with __morestack_non_split, supplies a non-split-stack
> function with at least 0x100000 (1M) available stack.  On powerpc64, a
> default of 0x4000 is not large enough to reliably work with the golang
> testsuite.  This increase the default size to the defacto x86 value.
>
>         * options.h (split_stack_adjust_size): Default to 0x100000.
>
> diff --git a/gold/options.h b/gold/options.h
> index bc211151de..51d3614e6b 100644
> --- a/gold/options.h
> +++ b/gold/options.h
> @@ -1260,7 +1260,7 @@ class General_options
>                  "output sections"),
>               N_("(PowerPC only) Each output section has its own stubs"));
>
> -  DEFINE_uint(split_stack_adjust_size, options::TWO_DASHES, '\0', 0x4000,
> +  DEFINE_uint(split_stack_adjust_size, options::TWO_DASHES, '\0', 0x100000,
>               N_("Stack size when -fsplit-stack function calls non-split"),
>               N_("SIZE"));

This is OK.  Thanks for following up on it.

Ian


More information about the Binutils mailing list