[PATCH] ld: Run PR ld/26936 test only if supported
Alan Modra
amodra@gmail.com
Sun Nov 29 23:44:54 GMT 2020
On Sat, Nov 28, 2020 at 07:34:32AM -0800, H.J. Lu wrote:
> On Fri, Nov 27, 2020 at 6:31 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Fri, Nov 27, 2020 at 2:27 PM Alan Modra <amodra@gmail.com> wrote:
> > >
> > > On Fri, Nov 27, 2020 at 04:57:05PM +0100, Hans-Peter Nilsson via Binutils wrote:
> > > > I'll have to investigate this on my side.
> > >
> > > FWIW, I didn't see any cris fails either. My current list of fails
> > > for the new test is:
> > >
> > > $ grep 26936 gastest_results
> > > am33_2.0-linux FAIL: ld-elf/pr26936
>
> Different numbers of local symbols in linkonce section and comdat sections.
>
> > > arc-elf FAIL: ld-elf/pr26936
>
> -Ttext-segment is ignored:
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=26970
>
> > > arm-symbianelf FAIL: ld-elf/pr26936
>
> Obsoleted.
>
> > > hppa64-hp-hpux11.23 FAIL: ld-elf/pr26936
>
> The assembly source file is renamed.
>
> > > mips-sgi-irix6 FAIL: ld-elf/pr26936
>
> Section names in symbol table.
>
> > > mipstx39-elf FAIL: ld-elf/pr26936
>
> Likewise.
>
> > > mn10300-elf FAIL: ld-elf/pr26936
>
> Different numbers of local symbols in linkonce section and comdat sections.
>
> > > riscv64-linux FAIL: ld-elf/pr26936
>
> Likewise.
>
> > > xtensa-elf FAIL: ld-elf/pr26936
>
> Comdat groups always have more than one member.
Thank you for looking into why various targets fail.
> PR ld/26936
> * testsuite/ld-elf/pr26936.d: Run only if mixing linkonce and
> comdat sections is supported.
> * testsuite/lib/ld-lib.exp (check_mix_linkonce_comdat_support):
> New proc.
This is OK. However I do think check_mix_linkonce_comdat_support is
overkill. Yes, it would cover some future target that did the same as
xtensa in adding target sections to groups, but as far as I'm aware
xtensa is the only target that fails the test due to adding extra
sections to a group. So xfail xtensa*-*-* would be sufficient, and
easier to fix the test for xtense by say, passing a special flag to
gas to disable property sections on xtensa. It's a bit more difficult
to arrange to do that for ld-lib.exp tests.
Also, I prefer xfail rather than notarget in many situations, because
tests can easily be left disabled once the underlying bug is fixed.
But again, I don't object to you committing the patch as is.
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list