PR26936 testsuite fixes

Alan Modra amodra@gmail.com
Thu Nov 26 08:08:00 GMT 2020


Many targets fail this test due to -z noseparate-code not being
supported, or _start not being the proper entry symbol, or "as -g"
something other than "generate debug".  This fixes most but not all of
the fails.

	PR 26936
	* testsuite/ld-elf/pr26936.d: Pass --gen-debug to gas rather than -g.
	Only run when -shared -z options are supported.
	* testsuite/ld-elf/pr26936b.s: Define more entry symbols.

diff --git a/ld/testsuite/ld-elf/pr26936.d b/ld/testsuite/ld-elf/pr26936.d
index b007e83ff2..3c854fa0b5 100644
--- a/ld/testsuite/ld-elf/pr26936.d
+++ b/ld/testsuite/ld-elf/pr26936.d
@@ -1,9 +1,10 @@
 #source: pr26936a.s
 #source: pr26936b.s
 #source: pr26936c.s
-#as: -g
+#as: --gen-debug
 #ld: -z noseparate-code -Ttext-segment 0x10000 -z max-page-size=0x1000
 #readelf: -wL
+#target: [check_shared_lib_support]
 
 #...
 CU: .*/pr26936c.s:
diff --git a/ld/testsuite/ld-elf/pr26936b.s b/ld/testsuite/ld-elf/pr26936b.s
index 433528c33e..6ce9fd0441 100644
--- a/ld/testsuite/ld-elf/pr26936b.s
+++ b/ld/testsuite/ld-elf/pr26936b.s
@@ -1,7 +1,19 @@
 	.text
-	.globl _start
+	.type start,"function"
+	.global start
+start:
+	.type _start,"function"
+	.global _start
 _start:
-	.type   _start, %function
+	.type __start,"function"
+	.global __start
+__start:
+	.type main,"function"
+	.global main
+main:
+	.type _main,"function"
+	.global _main
+_main:
 	.nop
 	.section .text.__x86.get_pc_thunk.bx,"axG",%progbits,__x86.get_pc_thunk.bx,comdat
 	.globl  __x86.get_pc_thunk.bx

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list