[PATCH 03/12] objdump, readelf: Report errors from CTF archive iteration

Nick Alcock nick.alcock@oracle.com
Wed Nov 18 16:20:39 GMT 2020


On 17 Nov 2020, Alan Modra spake thusly:

> On Sun, Oct 25, 2020 at 02:14:04PM +0000, Nick Alcock via Binutils wrote:
>> -  ctf_archive_iter (ctfa, dump_ctf_archive_member, parent);
>> +  if ((err = ctf_archive_iter (ctfa, dump_ctf_archive_member, parent)) != 0)
>> +    {
>> +      dump_ctf_errs (NULL);
>> +      fatal (_("CTF archive member open failure: %s"), ctf_errmsg (err));
>> +      bfd_fatal (bfd_get_filename (abfd));
>
> fatal calls xexit, which makes bfd_fatal here dead code.

Oops! That should be a non_fatal, obviously, like the calls above.
Fixed.


More information about the Binutils mailing list