[PATCH 04/12] bfd, include, ld, binutils, libctf: CTF should use the dynstr/sym
Nick Alcock
nick.alcock@oracle.com
Wed Nov 18 15:52:46 GMT 2020
On 17 Nov 2020, Alan Modra told this:
> On Sun, Oct 25, 2020 at 02:14:05PM +0000, Nick Alcock via Binutils wrote:
>> Some bits might be contentious. The ctf_new_dynstr callback takes an
>> elf_internal_sym, and this remains an elf_internal_sym right down
>> through the generic emulation layers into ldelfgen. This is no worse
>
> Yeah, I would have preferred not needing elf/internal.h in ld, but
> it's not so unreasonable in ELF specific ld files.
>
> So, patch is OK. I think that gets you to the point where you can
> commit the patch series.
Thank you! I'll rebase and do the usual round of retesting, then if that
passes -- which it should -- push (in the next day, probably).
Next: getting the lookup side to work better. I've been writing a lookup
testsuite and finding a lot of lookup-side bugs, mostly in places where
GCC generates CTF that is much more faithful to the original type graph
than the pre-existing DWARF converters ever did. (Not a precondition for
this series to go in: this is a strict improvement on its own.)
More information about the Binutils
mailing list