[PATCH 8/9] Fix the decoding of DW_FORM_ref_addr DWARF attribute.

H.J. Lu hjl.tools@gmail.com
Sun Nov 15 22:57:00 GMT 2020


On Sun, Nov 15, 2020 at 2:47 PM Mark Wielaard <mark@klomp.org> wrote:
>
> On Sun, 2020-11-15 at 09:29 -0800, H.J. Lu wrote:
> > I think you also need to backport:
> >
> > commit 76868f3606fb9de04f49c441c1e3cdd3e943a34d
> > Author: H.J. Lu <hjl.tools@gmail.com>
> > Date:   Thu Oct 29 09:19:25 2020 -0700
> >
> >     dwarf: Also match abbrev base when searching abbrev list
> >
> >     A .debug_abbrev section can have multiple CUs.  When caching abbrev list,
> >     we need to check abbrev base to support multiple CUs.
> >
> >             PR binutils/26808
> >             * dwarf.c (abbrev_list): Add abbrev_base.
> >             (new_abbrev_list): Add an abbrev_base argument and record it.
> >             (find_abbrev_list_by_abbrev_offset): Add an abbrev_base argument
> >             and match it.
> >             (process_debug_info): Pass abbrev_base to new_abbrev_list and
> >             find_abbrev_list_by_abbrev_offset.
> >             (display_debug_abbrev): Pass 0 abbrev_base to new_abbrev_list
> >             and find_abbrev_list_by_abbrev_offset.
> >             * testsuite/binutils-all/x86-64/pr26808.dump: New file.
> >             * testsuite/binutils-all/x86-64/pr26808.dwp.bz2: Likewise.
> >             * testsuite/binutils-all/x86-64/x86-64.exp: Run PR binutils/26808
> >             test.
>
> I believe that only affects dwp (DWARF Packaging) files and none of the
> tools I am testing handles dwp files (yet).
>
> The patch looks correct though, so I certainly don't mind it being
> backported. It seems a useful bugfix.
>

I ran into it in gold testsuite on master.   Have you enabled gold
with your backports?

-- 
H.J.


More information about the Binutils mailing list